[PATCH] D31414: [NFC, Refactor] Modernize TemplateIdAnnotation using TrailingObjects

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: include/clang/Sema/ParsedTemplate.h:202
+           SmallVectorImpl<TemplateIdAnnotation *> &CleanupList) {
+      ;
+      TemplateIdAnnotation *TemplateId = new (std::malloc(
----------------
Spurious semi colon?


================
Comment at: include/clang/Sema/ParsedTemplate.h:215
+                    [](ParsedTemplateArgument &a) {
+                      return a.~ParsedTemplateArgument();
+                    });
----------------
Why is this returning the result of an explicit destructor call?

Also `a` should be named `A` per usual naming conventions.


https://reviews.llvm.org/D31414