[PATCH] D32480: clang-format: Add CompactNamespaces option
Francois Ferrand via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 22 05:49:23 PDT 2017
Typz added a comment.
Merging the 2 options is definitely a "safe" option, as it prevents ensures only the most obvious behavior is accessible.
However, it has significant (IMO) drawbacks:
- "Compact" is a not an namespace indentation type, this will make the option quite confusing
- If indentation inside compact namespaces is needed, it cannot easily be added: we would need an extra mode NI_CompactWithIndent
All in all, I think I prefer the current behavior of the patch (a separate CompactNamespace options, with consistent [if not useful] indentation settings); but it is your call, just let me know how to proceed.
https://reviews.llvm.org/D32480
More information about the cfe-commits
mailing list