[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).
Krasimir Georgiev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 22 04:57:14 PDT 2017
krasimir added inline comments.
================
Comment at: clangd/tool/ClangdMain.cpp:11
+#include "../ClangdLSPServer.h"
+#include "../JSONRPCDispatcher.h"
#include "llvm/Support/CommandLine.h"
----------------
I'd suggest to not have parent directory includes, but add them to the cmake file as in other extra tools, like in:
https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-query/tool/CMakeLists.txt
https://reviews.llvm.org/D33395
More information about the cfe-commits
mailing list