[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Piotr Padlewski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 21 01:42:55 PDT 2017


Prazek added a comment.

In https://reviews.llvm.org/D19201#760151, @aaron.ballman wrote:

> As an FYI, there is a related check being implemented in clang currently; we probably should not duplicate this effort. See https://reviews.llvm.org/D33333.


I think that clang is the right place for this feature, but I am not sure if the patch has all the features (like checking if something will be catched, or not showing warning for conditional noexcepts, which as we have seen
could be a problem for some projects. There also might be some other corner cases that we didn't think about. 
Assuming that this patch is ready to land, I would propose to send it to trunk and remove it when the clang's patch will make it to the trunk. I am not sure how much time it will take for other patch to be ready, but maybe we could gather some usefull bug reports in the meantime and also Stanislaw would have a contribution.


https://reviews.llvm.org/D19201





More information about the cfe-commits mailing list