[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

[Piotr Padlewski via Phabricator via cfe-commits]

Prazek added inline comments.


================
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:76
+
+  for (const auto Parent : Context->getParents(node)) {
+    if (isCaughtInFunction(Context, Throw, Function, Parent))
----------------
unnecessary braces


================
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:113-115
+  if (isCaughtInFunction(Result.Context, Throw, Function, ThrowNode)) {
+    return;
+  }
----------------
unnecessary braces


================
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:126-131
+
+  for (const auto &NoExceptRange : NoExceptRanges) {
+    diag(NoExceptRange.getBegin(),
+         "in a function declared nothrow here", DiagnosticIDs::Note)
+        << FixItHint::CreateRemoval(NoExceptRange);
+  }
----------------
same here


https://reviews.llvm.org/D19201