[PATCH] D33272: Method loadFromCommandLine should be able to report errors

[Serge Pavlov via Phabricator via cfe-commits]

sepavloff added a comment.

In https://reviews.llvm.org/D33272#758616, @joerg wrote:

> Can this use ErrorOr?


It makes sense if constructing methods of `CompilationDatabase` were also changed to return `ErrorOr`, as there is no need to have different interfaces for the similar functionality. On the other hand, such change would not present a gain over existing implementation IMHO.


https://reviews.llvm.org/D33272