[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC
Bruno Cardoso Lopes via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 19 09:56:42 PDT 2017
bruno marked 3 inline comments as done.
bruno added a comment.
> I think the problem is that we don't take module visibility into account when doing redefinition checking for enumerators. Instead of passing through this flag, we should probably just ignore hidden declarations when checking for a redefinition of an enumerator.
Right, now that the patch changed to only merge the definition after the structural check it does makes sense to do that.
https://reviews.llvm.org/D31778
More information about the cfe-commits
mailing list