[PATCH] D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ updated this revision to Diff 99300.
NoQ added a comment.
Herald added a subscriber: xazax.hun.

Automatically pop up from bodyfarm-originated code in `PathDiagnosticLocation::getStmt()`.

Avoid putting "Calling..." and "Returning..." notes on Objective-C auto-synthesized property calls, because they would never call visible code later.

Test the newly added path notes.


https://reviews.llvm.org/D32437

Files:
  include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h
  lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
  lib/StaticAnalyzer/Core/PathDiagnostic.cpp
  test/Analysis/nullability-notes.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32437.99300.patch
Type: text/x-patch
Size: 5165 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170517/42a39b09/attachment.bin>