[PATCH] D33201: [ClangD] Refactor ProtocolHandlers to decouple them from ClangdLSPServer

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 16 05:29:25 PDT 2017


krasimir added inline comments.


================
Comment at: clangd/ClangdLSPServer.cpp:20
+template <typename T>
+std::string replacementsToEdits(StringRef Code, const T &Replacements) {
+  // Turn the replacements into the format specified by the Language Server
----------------
Hm, this is a bit too generic for my taste. Is it ever used generically?


https://reviews.llvm.org/D33201





More information about the cfe-commits mailing list