[PATCH] D33209: [clang-tidy] Add "emplace_back" detection in inefficient-vector-operation.

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added a subscriber: cfe-commits.
malcolm.parsons added inline comments.


================
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:92
+  const auto VectorAppendCall = expr(
+      anyOf(VectorAppendCallExpr, exprWithCleanups(has(VectorAppendCallExpr))));
   const auto VectorVarDefStmt =
----------------
I'd use ignoringImplicit(VectorAppendCallExpr) to ignore ExprWithCleanups.


Repository:
  rL LLVM

https://reviews.llvm.org/D33209