[PATCH] D33207: Fix an assertion failure in FormatASTNodeDiagnosticArgument.

[Richard Smith via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: test/SemaCXX/warn-shadow.cpp:214
+void handleLinkageSpec() {
+  typedef void externC; // expected-warning {{declaration shadows a typedef in linkage specification}}
+}
----------------
We should be producing a diagnostic talking about the enclosing namespace / TU scope, not the linkage specification. Whoever is emitting the diagnostic seems to be missing a call to `getRedeclContext()` -- although perhaps we could do that in the diagnostic code instead.


https://reviews.llvm.org/D33207