[PATCH] D33010: Make google-build-using-namespace skip std::.*literals
Martin Ejdestig via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 15 08:52:56 PDT 2017
marejde added a comment.
> Do you need me to commit the patch for you?
Yes please. I do not have commit access.
================
Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48
+bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace(
+ const NamespaceDecl *NS) {
----------------
alexfh wrote:
> Please make this a static free function instead, since it doesn't need access to the check's members.
Done.
https://reviews.llvm.org/D33010
More information about the cfe-commits
mailing list