[PATCH] D33173: Modify test to look for patterns in stderr as well

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 04:46:35 PDT 2017


alexfh added a comment.

Feel free to commit this to fix buildbots, however the underlying https://reviews.llvm.org/D33013 raises some questions.

Clang-tidy is also used as a library, in which case it should capture all compiler diagnostics and pass them to the caller. This test verifies that clang-tidy actually captures the compilation error, and with https://reviews.llvm.org/D33013 this seems to have broken for the diagnostics related to command line parsing. Modifying the driver to directly output these errors to stderr instead of using `DiagnosticConsumer` seems like a wrong thing to do.


https://reviews.llvm.org/D33173





More information about the cfe-commits mailing list