[PATCH] D33082: Fix Libc++ build with MinGW64

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 10 23:19:27 PDT 2017


smeenai added a comment.

@EricWF and I discussed this on IRC a bit. I'm not a fan of overloading `_LIBCPP_WIN32API` for this purpose, since to me that macro is meant for guarding Windows API functions, not for CRT functions. Eric suggested adding a new macro `_LIBCPP_MSVCRT_LIKE`, which I'd be fine with.


https://reviews.llvm.org/D33082





More information about the cfe-commits mailing list