[PATCH] D33030: [libcxxabi] Align unwindHeader on a double-word boundary

[Akira Hatanaka via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL302763: [libcxxabi] Align unwindHeader on a double-word boundary. (authored by ahatanak).

Changed prior to commit:
  https://reviews.llvm.org/D33030?vs=98401&id=98583#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D33030

Files:
  libcxxabi/trunk/src/cxa_exception.hpp
  libcxxabi/trunk/test/exception_object_alignment.sh.cpp


Index: libcxxabi/trunk/test/exception_object_alignment.sh.cpp
===================================================================
--- libcxxabi/trunk/test/exception_object_alignment.sh.cpp
+++ libcxxabi/trunk/test/exception_object_alignment.sh.cpp
@@ -0,0 +1,46 @@
+//===---------------- exception_object_alignment.sh.cpp -------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: libcxxabi-no-exceptions
+
+// RUN: %cxx %flags %compile_flags -O1 %s -o %t.exe
+// RUN: %exec %t.exe
+
+// This test used to segfault on Darwin because field unwindHeader of struct
+// __cxa_exception was not 16B aligned.
+
+namespace {
+
+struct S {
+  int a;
+  int __attribute__((aligned(16))) b;
+};
+
+class base1 {
+protected:
+  virtual ~base1() throw() {}
+};
+
+class derived: public base1 {
+public:
+  derived() : member() {}
+private:
+  S member;
+};
+
+}
+
+int main() {
+  try {
+    throw derived();
+  }
+  catch(...) {
+  }
+  return 0;
+}
Index: libcxxabi/trunk/src/cxa_exception.hpp
===================================================================
--- libcxxabi/trunk/src/cxa_exception.hpp
+++ libcxxabi/trunk/src/cxa_exception.hpp
@@ -61,7 +61,13 @@
     size_t referenceCount;
 #endif
 
-    _Unwind_Exception unwindHeader;
+    // This field is annotated with attribute aligned so that the exception
+    // object following the field is sufficiently aligned and there is no
+    // gap between the field and the exception object. r276215 made a change to
+    // annotate _Unwind_Exception with __attribute__((aligned)), but we cannot
+    // incorporate the fix on Darwin since it is an ABI-breaking change, which
+    // is why we need the attribute on this field.
+    _Unwind_Exception unwindHeader __attribute__((aligned));
 };
 
 // http://sourcery.mentor.com/archives/cxx-abi-dev/msg01924.html
@@ -96,7 +102,9 @@
     void* primaryException;
 #endif
 
-    _Unwind_Exception unwindHeader;
+    // See the comment in __cxa_exception as to why this field has attribute
+    // aligned.
+    _Unwind_Exception unwindHeader __attribute__((aligned));
 };
 
 struct _LIBCXXABI_HIDDEN __cxa_eh_globals {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33030.98583.patch
Type: text/x-patch
Size: 2379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170511/be1fa79d/attachment.bin>