[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

Wei-Ren Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 10 05:50:22 PDT 2017


chenwj added a comment.

In https://reviews.llvm.org/D32759#748916, @efriedma wrote:

> In https://reviews.llvm.org/D32759#748653, @chenwj wrote:
>
> > In https://reviews.llvm.org/D32759#748007, @efriedma wrote:
> >
> > > The difference between returning true and false here is just the way error recovery works: when we return true, we know the type is invalid, so we suppress it, and subsequent errors involving the declaration.  Example (Objective-C++) where we currently print two errors:
> >
> >
> > So when we see `T->isObjCObjectType()` is true, then we should return true since the return type is invalid?
>
>
> Yes.


@efriedma So @erichkeane 's patch looks okay?


https://reviews.llvm.org/D32759





More information about the cfe-commits mailing list