[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 9 10:17:12 PDT 2017


dexonsmith added a comment.

In https://reviews.llvm.org/D32724#747728, @aprantl wrote:

> Is it the right solution to use the module hash for correctness, or should the mismatch of the serialized langopts trigger a module rebuild and the module hash is only there to tune the performance/disk size tradeoff?


I'm not sure if there is (or should be) a hard-and-fast rule, but certainly in this case changing the hash SGTM.  Otherwise, users toggling back and forth between build configurations would have to rebuild the modules each time.


https://reviews.llvm.org/D32724





More information about the cfe-commits mailing list