[PATCH] D32984: [Sema] Implement Core 2094: Trivial copy/move constructor for class with volatile member

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 8 16:22:24 PDT 2017


rsmith added inline comments.


================
Comment at: test/CXX/drs/dr4xx.cpp:1205
 
-namespace dr496 { // dr496: no
+namespace dr496 { // dr496: reverted by dr2095 in 5.0
   struct A { int n; };
----------------
Write this as "dr496: sup 2094" and then rerun the `make_cxx_dr_status` script in www/ to regenerate cxx_dr_status.html


================
Comment at: test/CXX/drs/dr4xx.cpp:1209
   int check1[ __is_trivially_copyable(const int) ? 1 : -1];
-  int check2[!__is_trivially_copyable(volatile int) ? 1 : -1];
+  // FIXME: This checks the dr2095 behavior, not dr496
+  int check2[ __is_trivially_copyable(volatile int) ? 1 : -1];
----------------
2095 -> 2094? Also, why FIXME?


https://reviews.llvm.org/D32984





More information about the cfe-commits mailing list