[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

Billy Robert O'Neal III via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 02:01:14 PDT 2017


BillyONeal added inline comments.


================
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146
+        auto res = std::gcd(static_cast<int64_t>(1234), INT32_MIN);
+        static_assert(std::is_same<decltype(res), std::common_type_t<int64_t, int32_t>>::value, "");
         assert(res == 2);
----------------
EricWF wrote:
> `std::common_type` here please. This test runs in C++03 where we don't have `std::foo_t`.
C++17 library features in C++03?!? :(

OK, will fix.



https://reviews.llvm.org/D32309





More information about the cfe-commits mailing list