[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

Breaking the ABI of that configuration SGTM.



================
Comment at: src/memory.cpp:126-130
 const void*
 __shared_weak_count::__get_deleter(const type_info&) const _NOEXCEPT
 {
-    return 0;
+    return nullptr;
 }
----------------
If this is the right change, seems like the 0/nullptr change can be a separate NFC pre-commit.

However, I wonder if this should call std::terminate or abort or something.
- Previously, if someone with RTTI accidentally linked against such a library, they'd get a link error in this case.
- Now, what happens?


https://reviews.llvm.org/D32838