[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 3 08:22:58 PDT 2017
erichkeane added a comment.
In https://reviews.llvm.org/D32759#744613, @chenwj wrote:
> > Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m (line 11). I ran the lit tests initially with a breakpoint on this line and it never hit, though I must have set up the debugger wrong. Once I replaced it with an assert, method-bad-param failed.
>
> The fix LGTM. Is it possible to tweak method-bad-param.m so that we can see the difference after the fix?
I actually couldn't come up with a way where we COULD see the difference... I was hoiping someone else could come up with something if it were important enough for us.
https://reviews.llvm.org/D32759
More information about the cfe-commits
mailing list