[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 3 07:01:00 PDT 2017


alexfh added a comment.

Thank you! One comment inline.



================
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23
 
+AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) {
+  return true;
----------------
This should be a node matcher rather than a narrowing matcher, and it should be placed to ASTMatchers.h, if there is no such matcher already.


https://reviews.llvm.org/D32767





More information about the cfe-commits mailing list