[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

[Stephan T. Lavavej via Phabricator via cfe-commits]

STL_MSFT accepted this revision.
STL_MSFT added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/support/archetypes.hpp:20
 protected:
+#endif // !TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK
   NullBase() = default;
----------------
I think that this comment doesn't match the ifndef check, but it's a style question.


================
Comment at: test/support/archetypes.ipp:10
+#ifdef TEST_WORKAROUND_EDG_EXPLICIT_CONSTEXPR
+#define DEFINE_CONSTEXPR
+#else // TEST_WORKAROUND_EDG_EXPLICIT_CONSTEXPR
----------------
Should you define it to be `inline` instead of nothing?


https://reviews.llvm.org/D32778