[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In https://reviews.llvm.org/D32759#743860, @rnk wrote:

> On cfe-dev you said "There IS a case in our tests where it would hit such an assertion". Does "our tests" here refer to the existing clang tests or Intel tests? I just want to make sure we have coverage of this codepath in the test suite. I don't care that much about crafting a test case that shows the behavior difference of fixing the return value.


Ah, sorry.  "Our Tests" means the lit test SemaObjC/method-bad-param.m (line 11).  I ran the lit tests initially with a breakpoint on this line and it never hit, though I must have set up the debugger wrong.  Once I replaced it with an assert, method-bad-param failed.


https://reviews.llvm.org/D32759