[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 10:48:42 PDT 2017


JonasToth added a comment.

i like the generalization.



================
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
                                        unless(isInTemplateInstantiation()))
                          .bind("call"),
                      this);
----------------
i think `this);` should move up a line. clang-format seems to make this all the time. 


https://reviews.llvm.org/D32690





More information about the cfe-commits mailing list