[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

Yuka Takahashi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 1 23:29:12 PDT 2017


yamaguchi added inline comments.


================
Comment at: lib/Sema/SemaInit.cpp:875
 
   if (!VerifyOnly) {
     StructuredSubobjectInitList->setType(T);
----------------
ruiu wrote:
> Is it intentional that you run the new code only when !VerifyOnly?
I think VerifyOnly is used to check if it is formal verification mode or not, and if VerifyOnly == 1, it is supposed to emit no diagnostics. So I think it is OK that this code is here, because this part of is code emits -Wmissing-braces if braces are not appropriate.


https://reviews.llvm.org/D32646





More information about the cfe-commits mailing list