[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

Jakub Kuderski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 30 17:01:57 PDT 2017


kuhar added a comment.

In https://reviews.llvm.org/D32690#741952, @JonasToth wrote:

> Would it make sense to add boost pairs/tuples support?


I think it can be added the same way it is possible to specify smart pointers and vector-like containers now. It would require users to provide both types and make functions (eg. thingy and make_thingy). I'm not sure if that would be any useful in practise, though.

> Something for a later check: the same logic should apply for `insert` and `emplace`, we should add support for these methods too.

Yeah, I plan to do that a few patches from now, after other things are improved.


https://reviews.llvm.org/D32690





More information about the cfe-commits mailing list