[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

Casey Carter via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 29 07:25:19 PDT 2017


CaseyCarter created this revision.

NOTE: Unlike my typical `variant` test PRs, this one is actually safe to merge - crazy, I know - since it only adds coverage while testing the VC++ STL.



- Define a new macro `_MSVC_STL_VER` to distinguish testing the VC++ standard library implementation in the style of `_LIBCPP_VER`.

- Enable the "constexpr extension" tests for variant's copy/move constructors on VC++

- Add some new "triviality extension" tests for variant's conformance to P0602, currently only enabled on VC++

- Workaround C1XX's buggy `__is_trivially_copyable` in the variant tests.


https://reviews.llvm.org/D32671

Files:
  test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
  test/std/utilities/variant/variant.variant/variant.assign/move.pass.cpp
  test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
  test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp
  test/support/msvc_stdlib_force_include.hpp
  test/support/test.workarounds/c1xx_broken_is_trivially_copyable.pass.cpp
  test/support/test_workarounds.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32671.97191.patch
Type: text/x-patch
Size: 9970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170429/a8b3eced/attachment-0001.bin>


More information about the cfe-commits mailing list