dexonsmith added a comment. rsmith: I just noticed you still have a red "X" here (since Phab won't let me "close"). I think I addressed your comments, but let me know if you want me to revert until you have time to look. https://reviews.llvm.org/D31856