[PATCH] D32603: Build the Apple-style stage2 with modules and full debug info

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

(Both changes SGTM, but I doubt you're looking for my advice on the CMake logic.)



================
Comment at: cmake/caches/Apple-stage2.cmake:31-32
 set(CMAKE_CXX_FLAGS "-fno-stack-protector -fno-common -Wno-profile-instr-unprofiled" CACHE STRING "")
-set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -gline-tables-only -DNDEBUG" CACHE STRING "")
-set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -gline-tables-only -DNDEBUG" CACHE STRING "")
 set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
----------------
It would simplify fallout, reverting, triaging issues, understanding compile time impact, etc., if the debug info change was left for a separate commit (maybe waiting a day).  Thoughts?


https://reviews.llvm.org/D32603