[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

[Daniel Marjamäki via Phabricator via cfe-commits]

danielmarjamaki added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:116
+    return false;
+  ConstraintManager &CM = State->getConstraintManager();
+  ProgramStateRef StTrue, StFalse;
----------------
xazax.hun wrote:
> Any reason why do you get the constraint manager and not using ProgramState::assume?
Mostly that it's just 1 call instead of 2. assumeDual() has some extra logic (early return , assertion). are there some special reason to use assume()?


Repository:
  rL LLVM

https://reviews.llvm.org/D30295