[PATCH] D32576: [Modules] Improve diagnostics for incomplete umbrella

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 26 18:54:23 PDT 2017


bruno created this revision.

One of the -Wincomplete-umbrella warnings diagnoses when a header is present in the directory but it's not present in the umbrella header. Currently, this warning only happens on top level modules; any submodule using an umbrella header does not get this warning. Fix that by also considering the submodules.


https://reviews.llvm.org/D32576

Files:
  include/clang/Lex/Preprocessor.h
  lib/Lex/PPLexerChange.cpp
  test/Modules/Inputs/incomplete-umbrella/Foo.framework/Headers/Bar.h
  test/Modules/Inputs/incomplete-umbrella/Foo.framework/Headers/FooPublic.h
  test/Modules/Inputs/incomplete-umbrella/Foo.framework/Modules/module.modulemap
  test/Modules/Inputs/incomplete-umbrella/Foo.framework/Modules/module.private.modulemap
  test/Modules/Inputs/incomplete-umbrella/Foo.framework/PrivateHeaders/Baz.h
  test/Modules/Inputs/incomplete-umbrella/Foo.framework/PrivateHeaders/Foo.h
  test/Modules/incomplete-umbrella.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32576.96857.patch
Type: text/x-patch
Size: 7362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170427/f1dd8210/attachment.bin>


More information about the cfe-commits mailing list