[PATCH] D32475: [clang-format] Don’t propagate AvoidBinPacking into argument subexpressions

Jacob Bandes-Storch via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 26 12:02:25 PDT 2017


jtbandes added inline comments.


================
Comment at: lib/Format/ContinuationIndenter.cpp:923
+    // Don't propagate AvoidBinPacking into subexpressions of arg/param lists.
+    if (Current.FakeLParens.size() > 0 &&
+        Current.FakeLParens.back() > prec::Comma) {
----------------
jtbandes wrote:
> djasper wrote:
> > I think you cannot get here if .size() is 0 as this is iterating over the elements.
> Good point, thanks.
Actually, I can probably just use `*I > prec::Comma`.


https://reviews.llvm.org/D32475





More information about the cfe-commits mailing list