[PATCH] D32395: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls

[Piotr Padlewski via Phabricator via cfe-commits]

Prazek added inline comments.


================
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
+  const auto *MakePairCall = Result.Nodes.getNodeAs<CallExpr>("make_pair");
+  assert(InnerCtorCall || MakePairCall);
 
----------------
kuhar wrote:
> Prazek wrote:
> > JDevlieghere wrote:
> > > It's highly recommended to put some kind of error message in the assertion statement, as per the LLVM coding standards.
> > would it be better to change it to
> > !innerCtorCall && !MakePairCall && "No .."
> I don't think that this logic would work here. `!first && !second` ensures both are null.
Yea, I forgot how to De Morgan


https://reviews.llvm.org/D32395