[PATCH] D32406: [Coverage][Windows] Null pointer dereference in CodeGenPGO::skipRegionMappingForDecl (fixes PR32761)

Mon Apr 24 13:54:26 PDT 2017

vsk added a comment.

> Are you sure you want to do that? This is the only use of this boolean.

IMO removing 'SkipCoverageMapping' isn't related to fixing the original bug. Since it's simple enough to make it a separate change, I thought it'd be best.

In https://reviews.llvm.org/D32406#735847, @rnk wrote:

> In https://reviews.llvm.org/D32406#735725, @vsk wrote:
>
> > // RUN: %clang_cc1 -cc1 -triple i686-pc-windows-msvc19.0.0 -emit-obj -fprofile-instrument=clang -fdelayed-template-parsing -fcoverage-mapping -dump-coverage-mapping -emit-llvm-only -main-file-name empty-destructor.cpp -o - %s
>
>
> This is probably closer to a minimal command line:
>  `%clang_cc1 -triple i686-windows -emit-llvm-only -fcoverage-mapping -dump-coverage-mapping %s`

I'll go with this. @adamf this is just missing '-fprofile-instrument=clang', otherwise it's fine.

> Is there something we can FileCheck in the IR?

Absolutely, I'll add in the checks.

https://reviews.llvm.org/D32406