[PATCH] D32406: [Coverage][Windows] Null pointer dereference in CodeGenPGO::skipRegionMappingForDecl (fixes PR32761)

[Vedant Kumar via Phabricator via cfe-commits]

vsk added a comment.

Thanks for your patch! I have a few requests.

First, please split off the SkipCoverageMapping change from this patch. If you don't have commit access yet, let me know and I can commit it for you. You can also ping Chris L for commit access.

Second, the test can be minimized a bit further. Here's what I got:

  // RUN: %clang_cc1 -cc1 -triple i686-pc-windows-msvc19.0.0 -emit-obj -fprofile-instrument=clang -fdelayed-template-parsing -fcoverage-mapping -dump-coverage-mapping -emit-llvm-only -main-file-name empty-destructor.cpp -o - %s
                                                                                                                                                                                                                                                                                                                                
  struct A {                                                                                                                                                                                                                                                                                                                    
    virtual ~A();                                                                                                                                                                                                                                                                                                               
  };                                                                                                                                                                                                                                                                                                                            
                                                                                                                                                                                                                                                                                                                                
  void PR32761() {                                                                                                                                                                                                                                                                                                              
    A a;                                                                                                                                                                                                                                                                                                                        
  }


https://reviews.llvm.org/D32406