[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

Raphael Isemann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 23 14:47:50 PDT 2017


teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

This also disables warnings for `-MD` and `-MMD` which shouldn't happen as we're actually compiling code here and are probably compiling a project. E.g. for people that use this mode to create dependency files while initially building (to figure out when to rebuild each object), this will effectively force `-w` to the whole build process which is not good.

I would just manually check for `-M` and `-MM` where we only run the preprocessor and where adding `-w` is safe. Also please add another test that we actually get the warnings for `-MD` and another one for `-MMD`.

Otherwise this look good.


https://reviews.llvm.org/D32341





More information about the cfe-commits mailing list