[PATCH] D32342: Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen

[Raphael Isemann via Phabricator via cfe-commits]

teemperor added a comment.

I think most of the changes are just necessary because we replaced `LLVM_MAIN_SRC_DIR` with `CMAKE_SOURCE_DIR` (all the added `../` and removed `docs`). On the other hand this is now in sync with the way the the clang doxygen.cfg is structured and it fixes the include paths, so I think this looks reasonable.



================
Comment at: docs/README.txt:61
+    cd <build-dir>
+    cmake cmake -DDOXYGEN_FOUND=true -DLLVM_ENABLE_DOXYGEN=true <src-dir>
+    make
----------------
`cmake cmake` => `cmake` and I guess `-DDOXYGEN_FOUND` =>`-DLLVM_ENABLE_DOXYGEN=On`.

And we really need documentation for building this. The only search results I find for this are instructions for the pre-CMake era.

Anyway, the intended way is (at least from what I can see) to just run:

    cmake -DLLVM_ENABLE_DOXYGEN=On <src-dir>
    make doxygen-llvm # for LLVM docs
    make doxygen-clang # for clang docs

instead of invoking doxygen by yourself. Could you change this?


https://reviews.llvm.org/D32342