[libcxx] r300941 - XFAIL Windows test failures under test/libcxx

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 18:48:04 PDT 2017


Author: ericwf
Date: Thu Apr 20 20:48:02 2017
New Revision: 300941

URL: http://llvm.org/viewvc/llvm-project?rev=300941&view=rev
Log:
XFAIL Windows test failures under test/libcxx

This patch XFAIL's a number of tests under test/libcxx when on Windows.
These failures need more investigation or patches to either Clang or libc++
but for now we don't want them to prevent the bot from going green.

Modified:
    libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp
    libcxx/trunk/test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp
    libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp
    libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp
    libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp
    libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp
    libcxx/trunk/test/libcxx/modules/inttypes_h_exports.sh.cpp
    libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp
    libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp
    libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp
    libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_unlock.pass.cpp
    libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_missing_unlock.fail.cpp
    libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_requires_capability.pass.cpp
    libcxx/trunk/utils/libcxx/test/config.py

Modified: libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp (original)
+++ libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,11 @@
 //
 //===----------------------------------------------------------------------===//
 
+// There appears to be a bug in VerifyDiagnosticReporter on Windows that
+// causes -verify to not see the emitted warnings even though they are
+// actually getting omitted.
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // REQUIRES: verify-support, diagnose-if-support
 // UNSUPPORTED: libcpp-has-no-threads
 

Modified: libcxx/trunk/test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp (original)
+++ libcxx/trunk/test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp Thu Apr 20 20:48:02 2017
@@ -10,6 +10,10 @@
 // test libc++'s implementation of align_val_t, and the relevent new/delete
 // overloads in all dialects when -faligned-allocation is present.
 
+// Libc++ defers to the underlying MSVC library to provide the new/delete
+// definitions, which does not yet provide aligned allocation
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // REQUIRES: -faligned-allocation
 
 // RUN: %build -faligned-allocation
@@ -74,4 +78,4 @@ int main() {
     assert(typeid(std::align_val_t).name() == std::string("St11align_val_t"));
   }
 #endif
-}
\ No newline at end of file
+}

Modified: libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails because the `from_bytes` call seems to result in a call
+// to 'abort()'
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // UNSUPPORTED: c++98, c++03
 
 // <locale>

Modified: libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp (original)
+++ libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails on Windows because the underlying libc headers on Windows
+// are not modular
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // REQUIRES: modules-support
 
 // Test that <cinttypes> re-exports <cstdint>

Modified: libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp (original)
+++ libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails on Windows because the underlying libc headers on Windows
+// are not modular
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // REQUIRES: modules-support
 // UNSUPPORTED: c++98, c++03
 

Modified: libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp (original)
+++ libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails on Windows because the underlying libc headers on Windows
+// are not modular
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // REQUIRES: modules-support
 
 // Test that <cstdint> re-exports <stdint.h>

Modified: libcxx/trunk/test/libcxx/modules/inttypes_h_exports.sh.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/modules/inttypes_h_exports.sh.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/modules/inttypes_h_exports.sh.cpp (original)
+++ libcxx/trunk/test/libcxx/modules/inttypes_h_exports.sh.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails on Windows because the underlying libc headers on Windows
+// are not modular
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // REQUIRES: modules-support
 
 // Test that intypes.h re-exports stdint.h

Modified: libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception.pass.cpp Thu Apr 20 20:48:02 2017
@@ -8,6 +8,9 @@
 //===----------------------------------------------------------------------===//
 //
 
+// This test depends on std::exception_ptr which has not yet been implemented.
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // UNSUPPORTED: libcpp-no-exceptions
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03

Modified: libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/thread/futures/futures.promise/set_exception_at_thread_exit.pass.cpp Thu Apr 20 20:48:02 2017
@@ -6,7 +6,9 @@
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
-//
+
+// This test depends on std::exception_ptr which has not yet been implemented.
+// XFAIL: LIBCXX-WINDOWS-FIXME
 
 // UNSUPPORTED: libcpp-no-exceptions
 // UNSUPPORTED: libcpp-has-no-threads

Modified: libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// On Windows Clang bugs out when both __declspec and __attribute__ are present,
+// the processing goes awry preventing the definition of the types.
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // UNSUPPORTED: libcpp-has-no-threads
 // REQUIRES: thread-safety
 

Modified: libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_unlock.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_unlock.pass.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_unlock.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_lock_unlock.pass.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// On Windows Clang bugs out when both __declspec and __attribute__ are present,
+// the processing goes awry preventing the definition of the types.
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // UNSUPPORTED: libcpp-has-no-threads
 // REQUIRES: thread-safety
 

Modified: libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_missing_unlock.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_missing_unlock.fail.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_missing_unlock.fail.cpp (original)
+++ libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_missing_unlock.fail.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// On Windows Clang bugs out when both __declspec and __attribute__ are present,
+// the processing goes awry preventing the definition of the types.
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // UNSUPPORTED: libcpp-has-no-threads
 // REQUIRES: thread-safety
 

Modified: libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_requires_capability.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_requires_capability.pass.cpp?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_requires_capability.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/thread/thread.mutex/thread_safety_requires_capability.pass.cpp Thu Apr 20 20:48:02 2017
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// On Windows Clang bugs out when both __declspec and __attribute__ are present,
+// the processing goes awry preventing the definition of the types.
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
 // UNSUPPORTED: libcpp-has-no-threads
 // REQUIRES: thread-safety
 

Modified: libcxx/trunk/utils/libcxx/test/config.py
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/libcxx/test/config.py?rev=300941&r1=300940&r2=300941&view=diff
==============================================================================
--- libcxx/trunk/utils/libcxx/test/config.py (original)
+++ libcxx/trunk/utils/libcxx/test/config.py Thu Apr 20 20:48:02 2017
@@ -418,7 +418,7 @@ class Configuration(object):
                 # initial Windows failures until they can be properly diagnosed
                 # and fixed. This allows easier detection of new test failures
                 # and regressions. Note: New failures should not be suppressed
-                # using this feature.
+                # using this feature. (Also see llvm.org/PR32730)
                 self.config.available_features.add('LIBCXX-WINDOWS-FIXME')
 
         # Attempt to detect the glibc version by querying for __GLIBC__




More information about the cfe-commits mailing list