[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 16:30:17 PDT 2017


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: CMakeLists.txt:119
+    set(LIBCXX_CXX_ABI_LIBNAME "vcruntime")
   else()
+    find_path(
----------------
Nit: I would rather see this be
```
elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND
        IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
```

That way we can avoid a level of nesting. 


https://reviews.llvm.org/D32320





More information about the cfe-commits mailing list