[libcxx] r300881 - Fix comment and remove incorrect linker flags in test configuration

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 13:22:20 PDT 2017


Author: ericwf
Date: Thu Apr 20 15:22:19 2017
New Revision: 300881

URL: http://llvm.org/viewvc/llvm-project?rev=300881&view=rev
Log:
Fix comment and remove incorrect linker flags in test configuration

Modified:
    libcxx/trunk/utils/libcxx/test/config.py

Modified: libcxx/trunk/utils/libcxx/test/config.py
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/libcxx/test/config.py?rev=300881&r1=300880&r2=300881&view=diff
==============================================================================
--- libcxx/trunk/utils/libcxx/test/config.py (original)
+++ libcxx/trunk/utils/libcxx/test/config.py Thu Apr 20 15:22:19 2017
@@ -414,7 +414,11 @@ class Configuration(object):
         if self.is_windows:
             self.config.available_features.add('windows')
             if self.cxx_stdlib_under_test == 'libc++':
-                # LIBCXX-WINDOWS-FIXME is a
+                # LIBCXX-WINDOWS-FIXME is the feature name used to XFAIL the
+                # initial Windows failures until they can be properly diagnosed
+                # and fixed. This allows easier detection of new test failures
+                # and regressions. Note: New failures should not be suppressed
+                # using this feature.
                 self.config.available_features.add('LIBCXX-WINDOWS-FIXME')
 
         # Attempt to detect the glibc version by querying for __GLIBC__
@@ -482,8 +486,6 @@ class Configuration(object):
             self.cxx.flags += ['-m32']
         # Use verbose output for better errors
         self.cxx.flags += ['-v']
-        if self.is_windows:
-            self.cxx.link_flags += ['-Wl,-v']
         sysroot = self.get_lit_conf('sysroot')
         if sysroot:
             self.cxx.flags += ['--sysroot', sysroot]




More information about the cfe-commits mailing list