[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 20 06:47:41 PDT 2017
NoQ added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/Store.cpp:440
// well, although in reality we should return the offset added to that
- // value.
+ // value. See also the similar FIXME in getLValueFieldOrIvar().
if (Base.isUnknownOrUndef() || Base.getAs<loc::ConcreteInt>())
----------------
NoQ wrote:
> Note that this code doesn't really trigger; we return `UnknownVal()` somewhere above, as shown on the newly added tests. I suspect we may be missing valid null dereferences because of that; will have a look.
This is also addressed by D32291.
https://reviews.llvm.org/D31982
More information about the cfe-commits
mailing list