[PATCH] D29827: [AVR] Add -mmcu option to the driver

[Leslie Zhai via Phabricator via cfe-commits]

xiangzhai accepted this revision.
xiangzhai added a comment.
This revision is now accepted and ready to land.

Hi Peter,

Thanks for your rebase! LGTM!

> Based on the context, the change from lib/Driver/Tools.cpp -> lib/Driver/ToolChains/CommonArgs.cpp seems most appropriate (Gnu.cpp seems to be about mapping LLVM options to GCC?)

Sorry for my mistake! yes, I am maintaining similar patch <https://github.com/isoft-linux/packages-core/blob/master/llvm/clang-add-our-own-gcc-toolchain-tripplet-to-clang-path.patch> for GCC toolchain triples :) also rebased to lib/Driver/ToolChains/CommonArgs.cpp for packaging llvm-4.0.0 <http://koji.isoft-linux.org/koji/buildinfo?buildID=5191>.

> And please do commit on my behalf, I haven't requested an account yet. Thanks!

I will commit it for you tomorrow if no **Need Review**!

Regards,
Leslie Zhai


https://reviews.llvm.org/D29827