[PATCH] D32187: [CodeGen][ObjC]
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 18 20:16:37 PDT 2017
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great. A few tweaks about the diagnostic and LGTM.
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4985
+def note_protected_by_objc_fast_enumeration : Note<
+ "jump enters Objective-c fast enumeration loop body">;
def note_protected_by_objc_try : Note<
----------------
Capitalization: "Objective-C"
It's probably better to just say "fast enumeration loop" and leave off "body".
https://reviews.llvm.org/D32187
More information about the cfe-commits
mailing list