[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 18 11:03:54 PDT 2017


alexfh accepted this revision.
alexfh added a comment.

LG with one nit.



================
Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:209
+         "the 'empty' method should be used to check "
+         "for emptiness instead of comparing to an empty object.")
+        << Hint;
----------------
nit: Please remove the trailing period to follow the style other diagnostic messages use.


Repository:
  rL LLVM

https://reviews.llvm.org/D31542





More information about the cfe-commits mailing list