[PATCH] D32081: Add support for editor placeholders to Clang's lexer

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added inline comments.


================
Comment at: include/clang/Basic/IdentifierTable.h:358
 
+  /// Return true if this identifier is an editor placeholder.
+  bool isEditorPlaceholder() const {
----------------
Nitpick: There should probably be an example in the doc comment.  The editor placeholder syntax isn't commonly known.


================
Comment at: include/clang/Driver/Options.td:1478
+  "fno-allow-editor-placeholders">, Group<f_Group>,
+  Flags<[CC1Option]>;
+
----------------
Does the negative -fno- option need to be CC1Option?  Later in this patch you seem to canonicalize on the positive form when passing to the frontend.


Repository:
  rL LLVM

https://reviews.llvm.org/D32081