r300487 - CodeGen: Let byval parameter use alloca address space

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 17 13:10:45 PDT 2017


Author: yaxunl
Date: Mon Apr 17 15:10:44 2017
New Revision: 300487

URL: http://llvm.org/viewvc/llvm-project?rev=300487&view=rev
Log:
CodeGen: Let byval parameter use alloca address space

Differential Revision: https://reviews.llvm.org/D32133

Added:
    cfe/trunk/test/CodeGenOpenCL/byval.cl
Modified:
    cfe/trunk/lib/CodeGen/CGCall.cpp

Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCall.cpp?rev=300487&r1=300486&r2=300487&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGCall.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGCall.cpp Mon Apr 17 15:10:44 2017
@@ -1586,9 +1586,10 @@ CodeGenTypes::GetFunctionType(const CGFu
 
     case ABIArgInfo::Indirect: {
       assert(NumIRArgs == 1);
-      // indirect arguments are always on the stack, which is addr space #0.
+      // indirect arguments are always on the stack, which is alloca addr space.
       llvm::Type *LTy = ConvertTypeForMem(it->type);
-      ArgTypes[FirstIRArg] = LTy->getPointerTo();
+      ArgTypes[FirstIRArg] = LTy->getPointerTo(
+          CGM.getDataLayout().getAllocaAddrSpace());
       break;
     }
 

Added: cfe/trunk/test/CodeGenOpenCL/byval.cl
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenOpenCL/byval.cl?rev=300487&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenOpenCL/byval.cl (added)
+++ cfe/trunk/test/CodeGenOpenCL/byval.cl Mon Apr 17 15:10:44 2017
@@ -0,0 +1,18 @@
+// RUN: %clang_cc1 -emit-llvm -o - -triple amdgcn %s | FileCheck %s
+// RUN: %clang_cc1 -emit-llvm -o - -triple amdgcn---amdgizcl %s | FileCheck %s -check-prefix=AMDGIZ
+
+struct A {
+  int x[100];
+};
+
+int f(struct A a);
+
+int g() {
+  struct A a;
+  // CHECK: call i32 @f(%struct.A* byval{{.*}}%a)
+  // AMDGIZ: call i32 @f(%struct.A addrspace(5)* byval{{.*}}%a)
+  return f(a);
+}
+
+// CHECK: declare i32 @f(%struct.A* byval{{.*}})
+// AMDGIZ: declare i32 @f(%struct.A addrspace(5)* byval{{.*}})




More information about the cfe-commits mailing list