[PATCH] D32092: Attribute inline

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 14 14:01:22 PDT 2017


aaron.ballman added a comment.

In https://reviews.llvm.org/D32092#727559, @zahiraam wrote:

> Yes I did compare "inline" with "declspec(inline)" and not with "__attribute((gnu_inline))" and didn't test it whit different specifiers. I can do that. 
>  If  behavior is different we probably have to add an additional attribute?


It's not that it needs an additional attribute, but that your patch will require additional work. However, my question remains unanswered: can you fix your project? Is this in a header file of some well-used library? We typically do not implement undocumented compiler features of other compilers unless there's a compelling reason to do so.


https://reviews.llvm.org/D32092





More information about the cfe-commits mailing list