[PATCH] D31996: Make Gentoo GNU GCC Config override whitespace tolerant

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 14 08:36:23 PDT 2017


erichkeane added a comment.

In https://reviews.llvm.org/D31996#727229, @mgorny wrote:

> Is there any specific reason you need this? Since the file is autogenerated, I don't think it matters very much to allow extra whiespace. But then, I do not think it hurts, so feel free to do it. The code LGTM; note that I haven't tested it, however.


In my case, a misbehaving copy of SVN caused the test for this to have a '\r\n' line ending on Windows.  I fixed my SVN, but also realized that tolerance for whitespace might be valuable, particularly since a human might decide to change this without the gcc-config tool and neglect a trailing space.  It scared me that this was a condition where it would APPEAR to work well (ie, configure it to the 'latest', but not realize it is being ignored), then be surprised later.


https://reviews.llvm.org/D31996





More information about the cfe-commits mailing list