[PATCH] D31167: Use FPContractModeKind universally

Thu Apr 13 07:45:23 PDT 2017

yaxunl added a comment.

In https://reviews.llvm.org/D31167#725705, @mehdi_amini wrote:

> I believe considering the goal of moving to using per-instruction FMF and kills the global backend option, this leads to a bitcode upgrade issue: OpenCL (or other) bitcode that were generated bitcode don't have the right FMF and will be upgraded conservatively.
>  Performance regression when upgrading bitcode are to be expected in general, so it is not a bug.
>  To recover, an option for an OpenCL backend would be to add a pass that set the expected FMF everywhere after bitcode upgrade.

Actually we are not concerned about old bitcodes. We are doing separate compile/link/codegen, but the bitcode we use in codegen is fresh from the same revision of llvm/clang. As long as the FMF carries the correct info from Clang we should be OK.

Repository:
  rL LLVM

https://reviews.llvm.org/D31167